e0ne's comments | Code Review

Why GitHub's pull requests are not good for code review

Published at March 12, 2019 · 1 min read

I hope many of you at lease once created or received pull requests in GitHub. Usually, before pull request is merged some code review process happens. Even after the last changes, code review functionality in GitHub is not really cool for day to day activities.

I think it’s mostly because of pull requests are not designed for code review. It just allows you to add a few comments to the code. It was designed to allow contributors to propose their patches from fork to the original repository. Usually, in small and maybe in a mid-size project, the code review process is a pretty quick and not frequent activity.

...

Code review: why do we need it?

Published at January 27, 2019 · 1 min read

I don’t want to argue about necessary of code review now. It’s to each team to specify rules on how to do it. I just want to share with you my opinion why do we need it on each project.

First of all, it’s about code knowledge sharing. It’s a great chance to share knowledge about the project with a team. More code reviews you do - more knowledge about the project you’ve got.
To learn something new. New practices, approaches, etc - you may know a lot of interesting doing the code review.
To be on the same page with a team. More code reviews mean more communications between team members. It helps you to understand what the team expects from you and how to write good code for the particular project. It’s kind of formal type of communications which helps to build a good Team.

...

Work with Gerrit: git review-update

Published at January 26, 2019 · 1 min read

If you work with Gerrit you use its CLI tool git review.

Working with OpenStack, I use it a lot every day. I need to update the last patch and send it to the Gerrit very often. That’s why I created one line script to execute git commit -a --amend && git review command.

I put it into the /usr/local/bin/git-review-update file with a following content:

 #!/bin/sh

git commit -a --amend && git review

Now, I can use git review-update command to update the last patch and send it to Gerrit. It’s a good example of the simplest and fastest solutions which works for me during the last two years. Of course, I have to read Contributing guide and propose a new command to git-review at some point.

...

#Code Review

Tags

Recent posts

Go 1.18: new features

Всё будет Kubernetes

2022 Relaunch

Everyday Blogging

I don't want this CI

Archives